My First Pull Request Part 2

May 10, 2020
2 minutes

It’s official, I contributed to a open source project! This is a continuation of my first pull request for DDclient.

I actually didn’t think I would be posting anything today, considering it’s been Mother’s Day and I haven’t been on the PC all that much.

Requesting the pull request was pretty straightforward within GitHub. It starts a dedicated conversation for the changes. For the most part, there was back and forth with me and one of the maintainers to understand how NameCheap works. Also, the maintainer asked me to change some of the naming to follow his updated conventions. Easy stuff to address.

That being said, I’m not a big fan of the layout of GitHub for pull requests though. Perhaps since I’m not using a dedicated IDE (just working off a local copy with vim), it was confusing trying to keep track of the edits requested. I basically flipped back and forth from the web browser and vim making sure that I lined up the suggestions.

Ultimately the final round of reviews just had lines of code changes within the PR where I could mark them as “accept” and it placed a commit for me. It kinda felt like “cheating”, but it got the job done.

Pull Request on Github

Beautiful! My small contribution went to the main codebase!

Prior to this, I’ve understood the basics of a pull request, but it was definitely enlightening going through the process myself. I’m super thankful to SuperSandro2000 for being patient and working with me on the review to get it closed. I think I’ll be doing some more reading or tutorials on pull requests on GitHub to make sure I didn’t miss something obvious that made this more difficult than it needed to be. On the other hand, perhaps with enough practice it will come more naturally to me.

Day 3 of #100DaysToOffload